[cmake] don't find_library for libm to avoid absolute path in OpenEXRTargets.cmake #1376
Conversation
|
|
|
Thanks for the fix and the contribution. The ASWF policy is to require signed commits, could you possibly re-commit this with a -s? That will add the "signed-off-by" line. The best thing to do is to overwrite this commit with a force push, something like "git reset HEAD~1; git commit -s -m ; git push -f". Alternatively, I'm happy to submit a separate PR with the change, to save you the hassle if you prefer. Thanks! |
|
You don't need the (and then the force push) This avoids losing any commit message you had originally. |
|
@russelltg, this slipped through the cracks but we're about to make a release and would like to include this. Could you take a minute and amend the commit with the signoff? Or let me know and I'll submit a duplicate PR myself. Thanks! |
…cmake Replication of AcademySoftwareFoundation#1376. Link against m instead of the complete path for libm. Signed-off-by: Cary Phillips <[email protected]>
|
@russelltg, one more ping before the upcoming release, can you kindly sign the commit? Thanks! |
russelltg
force-pushed
the
cmake_no_absolute_targeets
branch
from
6126950
to
256ff09
Compare
russelltg
force-pushed
the
cmake_no_absolute_targeets
branch
from
256ff09
to
57a1863
Compare
|
Yep, sorry about the delay. Thanks for the pings :) |
As is, if you do a
cmake -Bbuild -DBUILD_SHARED_LIBS=OFF -GNinja --fresh && DESTDIR=install ninja -C build installthen
build/install/usr/local/lib/cmake/OpenEXR/OpenEXRTargets.cmakewill reference the absolute path to libm, which is problematic for my usecase as I'm compiling against a sysroot then copying it and building against it elsewhere.This fixes that problem by just linking to
minstead of the path